RFR: 8308342: Remove MetaspaceClosure::Ref::keep_after_pushing()

[Ioi Lam]

On Fri, 19 May 2023 21:09:38 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> More CDS clean up:
>> 
>> - Remove the field `SourceObjInfo::_ref` since we have already cached its contents in fields such as `SourceObjInfo::_msotype` and `SourceObjInfo::_source_addr` 
>> - Since there's no need to keep the `_ref` around, we can remove the `Ref::keep_after_pushing()` API.
>> - Also `ArchiveBuilder::clean_up_src_obj_table()` is no longer necessary.
>
> LGTM.

Thanks @calvinccheung for the review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14042#issuecomment-1556088155