RFR: 8308116: jdk.test.lib.compiler.InMemoryJavaCompiler.compile does not close files [v4]

[Axel Boldt-Christmas]

On Mon, 22 May 2023 16:09:48 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> jdk.test.lib.compiler.InMemoryJavaCompiler.compile(String className, CharSequence sourceCode, String... options) creates a JavaFileManager but fails to close it after the CompilationTask is completed, leaving the file descriptors open until reference processing kicks in.
>> 
>> Graph below shows number of open file descriptors before and after this patch for a program which compiles dummy classes in a loop. 
>> <img width="1116" alt="Before and after" src="https://github.com/openjdk/jdk/assets/1139284/1ecfb32a-735b-4765-bcca-81f67a4c9816">
>> 
>> Testing: GHA and Oracle CI tier1-3. Tests using jdk.test.lib.compiler.InMemoryJavaCompiler also tested locally.
>
> Axel Boldt-Christmas has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Refactor to close JavaFileManager directly
>  - Revert "Feedback: Update Copyright years"
>    
>    This reverts commit 932ebc043f00c57873697500e6ff6a7764bbc185.
>  - Revert "Fix tests"
>    
>    This reverts commit 3223959a1f7f9db9b202128487c66cb7109d920a.

Thanks for the reviews

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14001#issuecomment-1559603482