RFR: 8307478: Implementation of Prepare to Restrict The Dynamic Loading of Agents [v4]

Alan Bateman alanb at openjdk.org
Tue May 23 15:11:18 UTC 2023


On Mon, 22 May 2023 23:06:44 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Alan Bateman has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>> 
>>  - Merge
>>  - Refresh package description
>>  - Merge
>>  - Tweak docs
>>  - Merge
>>  - Draft docs changes
>>  - Merge
>>  - Rename/cleanup
>>  - Merge
>>  - Initial commit
>
> test/jdk/com/sun/tools/attach/warnings/DynamicLoadWarningTest.java line 197:
> 
>> 195:             // launch application with the given VM options, waiting for it to terminate
>> 196:             Stream<String> s1 = Stream.of(vmopts);
>> 197:             Stream<String> s2 = Stream.of("Application", ""+listener.getLocalPort());
> 
> Nit: Spaces are missed around '+' sign at lines: 121, 180 and 197.

Okay, we can use Integer.toString and Long.toString instead.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13899#discussion_r1202171498


More information about the hotspot-runtime-dev mailing list