RFR: 8263464: NMT: assert in gtest os.release_multi_mappings_vm [v7]
Gerard Ziemski
gziemski at openjdk.org
Wed May 24 17:52:04 UTC 2023
On Tue, 23 May 2023 09:38:37 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Johan's feedback: add comments, handle pesky NULL
>
> src/hotspot/share/services/virtualMemoryTracker.cpp line 528:
>
>> 526: }
>> 527:
>> 528: if (size <= reserved_rgn->size() && reserved_rgn->contain_region(addr, size)) {
>
> A region which contains another must necessarily have at least the size of the contained region, therefore the size check is unnecessary.
Ah, I see now, you are correct. I will fix it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13813#discussion_r1204568242
More information about the hotspot-runtime-dev
mailing list