RFR: 8303215: Make thread stacks not use huge pages [v2]

Poonam Bajaj poonam at openjdk.org
Thu May 25 16:26:04 UTC 2023


On Tue, 23 May 2023 18:27:35 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Poonam Bajaj has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   call scan_default_large_page_size() in the beginning of large_page_init()
>
> src/hotspot/os/linux/os_linux.cpp line 929:
> 
>> 927:   }
>> 928:   assert(is_aligned(stack_size, os::vm_page_size()), "stack_size not aligned");
>> 929: 
> 
> Small misgiving here about having to scan /proc/meminfo anew for every thread start. The problem is os::large_page_init() bailing out early if UseLargePages=0, right, so we cannot rely on large page initialization?

Hi @tstuefe, I made this change. Please take a look. Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14105#discussion_r1205753718


More information about the hotspot-runtime-dev mailing list