RFR: 8303215: Make thread stacks not use huge pages [v4]

Poonam Bajaj poonam at openjdk.org
Wed May 31 16:19:39 UTC 2023


On Wed, 31 May 2023 05:54:54 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Poonam Bajaj has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   addressed second set of review comments
>
> src/hotspot/os/linux/os_linux.cpp line 934:
> 
>> 932:   size_t default_large_page_size = os::Linux::default_large_page_size();
>> 933:   if (default_large_page_size != 0) {
>> 934:     if (stack_size >= default_large_page_size && is_aligned(stack_size, default_large_page_size)) {
> 
> Nit: this could have been written as a single if-clause

Changed it. Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14105#discussion_r1211974667


More information about the hotspot-runtime-dev mailing list