RFR: 8315462: [REDO] runtime/NMT/SummarySanityCheck.java failed with "Total committed (MMMMMM) did not match the summarized committed (NNNNNN)" [v2]

[Thomas Stuefe]

On Tue, 7 Nov 2023 10:13:09 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> This is a PR for the [original PR](https://github.com/openjdk/jdk/pull/16237).
>
> Afshin Zafari has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'origin/master' into ___8315462
>  - 8315462: [REDO] runtime/NMT/SummarySanityCheck.java failed with "Total committed (MMMMMM) did not match the summarized committed (NNNNNN)"

src/hotspot/share/nmt/mallocTracker.cpp line 65:

> 63:   // Need to make sure that mtChunks don't get deallocated while the
> 64:   // copy is going on, because their size is adjusted using this
> 65:   // buffer in make_adjustment().

Since you are moving this, could you change the comment a bit to make clear it only refers to the ThreadCritical, not the rest of the function? E.g. "Need to lock to make sure...."

src/hotspot/share/nmt/mallocTracker.hpp line 184:

> 182:     MallocMemorySnapshot* s = const_cast<MallocMemorySnapshot*>(this);
> 183:     return s->by_type(mtThreadStack)->malloc_count();
> 184:   }

Why is this needed?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16262#discussion_r1384789216
PR Review Comment: https://git.openjdk.org/jdk/pull/16262#discussion_r1384796312