RFR: 8315462: [REDO] runtime/NMT/SummarySanityCheck.java failed with "Total committed (MMMMMM) did not match the summarized committed (NNNNNN)" [v2]

[Thomas Stuefe]

On Tue, 7 Nov 2023 12:04:17 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> src/hotspot/share/nmt/mallocTracker.hpp line 184:
>> 
>>> 182:     MallocMemorySnapshot* s = const_cast<MallocMemorySnapshot*>(this);
>>> 183:     return s->by_type(mtThreadStack)->malloc_count();
>>> 184:   }
>> 
>> Why is this needed?
>
> It came after merge, added in JDK-8315362.

Yes, JDK-8315362 threw this out. IIRC we removed the awkward mechanism of counting threads by number of thread stacks. Hence my question, why the re-introduction? Merge glitch?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16262#discussion_r1384905920