RFR: 8319630: Monitor final audit log lacks separator

David Holmes dholmes at openjdk.org
Wed Nov 8 05:38:00 UTC 2023


On Tue, 7 Nov 2023 14:01:08 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> There's a couple of problems with the "final audit" output for `is_busy` monitors.
> 
> 1) The contentions field lacks a ", " when `contentions()` returns 0
> 2) The owner field lacks a ", " when owner is non-null
> 
> Example output before the patch:
> 
> [20.122s][info][monitorinflation] 0x0000600003fb4010 100 0x0000080000200908 java.lang.ref.NativeReferenceQueue$Lock (is_busy: waiters=1, contentions=0owner=0x0000000000000000, cxq=0x0000000000000000, EntryList=0x0000000000000000)
> ``` 
> 
> Tested with manual inspection. I couldn't find a pre-existing test for this output, so my guess is that it's mainly for HotSpot developers?

Looks good.

Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16541#pullrequestreview-1719403303


More information about the hotspot-runtime-dev mailing list