RFR: 8319650: Improve heap dump performance with class metadata caching [v2]

Volker Simonis simonis at openjdk.org
Wed Nov 8 12:10:00 UTC 2023


On Wed, 8 Nov 2023 12:00:48 GMT, Volker Simonis <simonis at openjdk.org> wrote:

>> Aleksey Shipilev has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   Fix
>
> src/hotspot/share/services/heapDumper.cpp line 800:
> 
>> 798: private:
>> 799:   GrowableArray<char> _sigs_start;
>> 800:   GrowableArray<int> _offsets;
> 
> These arrays are allocated in the resource area so don't we need a resource mark somewhere around the usage of `DumperClassCacheTable` which creates these `DumperClassCacheTableEntry` objects?

Oh, never mind. I think I've reviewed an outdated version and you've added the resource mark with https://github.com/openjdk/jdk/pull/16545/commits/a19501f9df003c9370af037d12abcce352c7986f

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16545#discussion_r1386513826


More information about the hotspot-runtime-dev mailing list