RFR: 8316746: Top of lock-stack does not match the unlocked object [v5]

Martin Doerr mdoerr at openjdk.org
Wed Nov 8 16:50:29 UTC 2023


On Wed, 8 Nov 2023 11:09:29 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve comment.
>
> src/hotspot/cpu/ppc/templateTable_ppc_64.cpp line 4219:
> 
>> 4217:   __ beq(CCR0, Lallocate_new);
>> 4218:   __ mr(Rcurrent_monitor, Rfree_slot);
>> 4219:   __ b(Lfound);
> 
> Wouldn't it be nice to use `Rfree_slot` from here on and save the move to `Rcurrent_monitor` and the unconditional branch?
> 
>   __ cmpdi(CCR0, Rfree_slot, 0);
>   __ bne(CCR0, Lfound);

Good idea. Changed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16406#discussion_r1386922688


More information about the hotspot-runtime-dev mailing list