RFR: 8319554: Select LogOutput* directly for stdout and stderr

[Daniel D. Daugherty]

On Wed, 8 Nov 2023 19:09:33 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> src/hotspot/share/logging/logConfiguration.cpp line 513:
>> 
>>> 511:   } else if (0 == strcmp(outputstr, StderrLog->name())) { // stderr
>>> 512:     idx = 1;
>>> 513:     assert(find_output(outputstr) == idx, "sanity check");
>> 
>> This is the first time I see [Yoda conditions](https://en.wikipedia.org/wiki/Yoda_conditions) in HotSpot :-), maybe do `strcmp(...) == 0` instead?
>
> oh, I don't know there's a term for that. 
> 
> I guess I derive this from java. "stdout".equals(name) can compare name == null whereas name.equals("stdout") will throw NPE. 
>  
> okay. I will flip them.

Sometimes in HotSpot you will see:

void *ptr = nullptr;
<some code>
if (nullptr == ptr) {
  <some code>
}


Some folks code variable checks that way because this:

`if (nullptr = ptr)`

will result in a compiler error whereas:

`if (ptr = nullptr)`

will not result in a compiler error. I've never heard that style called a Yoda condition before...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16543#discussion_r1387091908