RFR: 8319554: Select LogOutput* directly for stdout and stderr [v2]

David Holmes dholmes at openjdk.org
Thu Nov 9 05:18:58 UTC 2023


On Wed, 8 Nov 2023 19:32:14 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> This patch skips allocation on C heap and invoking jio_snprintf for stdout and stderr. 
>> They are 2 predefined LogOuptuts and can't be deleted. 
>> 
>> We also check the return value of set_log_config in test_asynclog.cpp. if configuration fails,
>> the test will be skipped. We expect tot fix the flaky failures(JDK-8309067).
>
> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update style according to review feedback.
>   
>   1. avoid nested indentation.
>   2. avoid YODA conditions.

I'm not sure this will help with the other logging failures but the changes seem reasonable regardless.

Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16543#pullrequestreview-1721711749


More information about the hotspot-runtime-dev mailing list