RFR: JDK-8319704: LogTagSet::set_output_level() should not accept NULL as LogOutput [v2]

[David Holmes]

On Fri, 10 Nov 2023 13:11:12 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Trivial change to add an assert.
>> 
>> See [JDK-8319104](https://bugs.openjdk.org/browse/JDK-8319104)
>> 
>> `LogTagSet::set_output_level()` and `LogOutputList::set_output_level` should not accept NULL as LogOutput* argument.
>> 
>> They do, currently, which leads to delayed crashes later since the NULL output is registered in the output list.
>> 
>> That triggered [JDK-8319104](https://bugs.openjdk.org/browse/JDK-8319104), where - due to a fluke in C++ initialization order and a mislabeling of LogTagSet tests as "TEST", without "_VM" - `LogTagSet::set_output_level()` was called with `LogConfiguration::StdoutLog` which was still uninitialized (null). 
>> 
>> An assert would have saved investigation time.
>
> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update logOutputList.cpp

LGTM

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16555#pullrequestreview-1726483668