RFR: 8314243: Make VM_Exit::wait_for_threads_in_native_to_block wait for user threads time configurable

Jiangli Zhou jiangli at openjdk.org
Mon Nov 13 22:31:27 UTC 2023


On Mon, 13 Nov 2023 06:01:11 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> CSR: https://bugs.openjdk.org/browse/JDK-8314305
>
> src/hotspot/share/runtime/globals.hpp line 841:
> 
>> 839:           "Maximum delay in milliseconds at exit waiting for user threads " \
>> 840:           "in native")                                                      \
>> 841:           range(0, max_intx)                                                \
> 
> Given we are going to calculate the actual delay in 10ms chunks, then maybe this should be expressed as the number of 10ms chunks to wait? Otherwise 0-9 -> 0; 10-19->10; 20-29->20 etc.
> 
> And maybe we should limit the max to something big but sensible - like 10 seconds?

Sounds good for limiting the max to 10 seconds. Changing to the value to the the number of 10ms chucks also makes sense to me. Thanks for thinking through that detail.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16591#discussion_r1391772185


More information about the hotspot-runtime-dev mailing list