RFR: 8319896: Remove monitor deflation from final audit

[Stefan Karlsson]

On Fri, 10 Nov 2023 12:35:46 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> In [JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757) we can see that running a monitor deflation pass during a safepointed operation can interleave with the async monitor deflation, which causes various problems. The fix for that is to stop deflating monitors in the thread dump operation and instead only collect relevant monitors.
> 
> There is yet another place where we call monitor deflation from outside of the monitor deflation thread. That place is the "final audit" part, which walks over monitors and performs verification and logging just before we exit the JVM. Before the walk over the list of monitors we perform a monitor deflation pass to prune the system from "uninteresting" monitors.
> 
> I propose that we remove the monitor deflation from the final audit, and that we instead only visit "interesting" monitors (those that have an owner or "is busy"). After this change it's only the monitor deflation thread that performs monitor deflation. It is unclear to me if the final audit can actually interleave with the async monitor deflation, but this removal makes it easier to reason around monitor deflation since it is only one thread that is performing it.
> 
> This PR is dependent on #16519. I intend to run extended testing on both of these PRs over the weekend.

This passes tier1-8 on Linux x64.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16605#issuecomment-1809623528