RFR: 8314243: Make VM_Exit::wait_for_threads_in_native_to_block wait for user threads time configurable [v2]

Jiangli Zhou jiangli at openjdk.org
Tue Nov 14 23:34:32 UTC 2023


On Tue, 14 Nov 2023 05:59:27 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Incorporate feedback/suggestion from David Holmes:
>>   - Change the flag to be expressed as the number of 10ms chunks (i.e. number of wait attempts) to wait.
>>   - Limit the max allowed wait to 10s. That's 1000 wait attempts with each attempt=10ms.
>
> src/hotspot/share/runtime/vmOperations.cpp line 394:
> 
>> 392:   // better to terminate VM when current thread is the only active thread, so
>> 393:   // wait for user threads too. Numbers are in 10 milliseconds.
>> 394:   int wait_time_per_attempt = 10;                 // in milliseconds
> 
> Nit: either remove extra spaces before comment, or re-align with the comment on L396.

Will fix.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16591#discussion_r1393439000


More information about the hotspot-runtime-dev mailing list