RFR: 8319048: Monitor deflation unlink phase prolongs time to safepoint [v7]

Daniel D. Daugherty dcubed at openjdk.org
Fri Nov 17 00:27:34 UTC 2023


On Thu, 16 Nov 2023 20:21:27 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8319048-monitor-deflation-unlink
>>  - Merge branch 'master' into JDK-8319048-monitor-deflation-unlink
>>  - Move unlink_batch init to proper place
>>  - Add invariant checking
>>  - Merge branch 'master' into JDK-8319048-monitor-deflation-unlink
>>  - Fix test after recent test infra renames
>>  - Merge branch 'master' into JDK-8319048-monitor-deflation-unlink
>>  - Batch 500
>>  - Pre-final touchups
>>  - Option range and tests
>>  - ... and 1 more: https://git.openjdk.org/jdk/compare/bd5f2b6a...09863092
>
> OK, I think the previously blocking things are now in mainline. I remerged, and kicked off the testing re-runs. Please review meanwhile! Thanks.

@shipilev - Please hold off on integrating this change. The last time we made a change
like was in:

[JDK-8256302](https://bugs.openjdk.org/browse/JDK-8256302) releasing oopStorage when deflating allows for faster deleting

and that change might be the cause for a recent race that @pchilano is chasing:

[JDK-8319137](https://bugs.openjdk.org/browse/JDK-8319137) SetNameAtExit fails with "assert(!is_null()) failed: Must be created"

I would like to see how [JDK-8319137](https://bugs.openjdk.org/browse/JDK-8319137) settles out.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16412#issuecomment-1815540289


More information about the hotspot-runtime-dev mailing list