RFR: 8319896: Remove monitor deflation from final audit [v3]

Stefan Karlsson stefank at openjdk.org
Fri Nov 17 07:07:45 UTC 2023


On Thu, 16 Nov 2023 23:45:51 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update comments
>
> src/hotspot/share/runtime/synchronizer.cpp line 1624:
> 
>> 1622:   size_t unlinked_count = 0;
>> 1623:   size_t deleted_count = 0;
>> 1624:   if (deflated_count > 0) {
> 
> There's a conditional at line 1631 is_monitor_deflation_thread, and an else at 1657 that deflating idle monitors is at a safepoint.  Should there not be this conditional, ie am I reading the description right?

You are right. The plan in my head has been to remove the safepointed monitor deflation first and then take a pass over the code and remove the various blocks that we don't execute anymore.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16605#discussion_r1396779065


More information about the hotspot-runtime-dev mailing list