Integrated: 8319897: Move StackWatermark handling out of LockStack::contains

[Stefan Karlsson]

On Fri, 10 Nov 2023 13:04:56 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> There are StackWatermark handling inside LockStack::contains. This is an indication that either:
> 1) some thread has failed to start it's own StackWatermark processing, or
> 2) that some thread is looking into the oops of another thread without starting the StackWatermark handling. The latter is usually more common.
> 
> I propose that we hoist the StackWatermark processing out of the LockStack into the code that actually performs pokes around in other thread's data. This is usually where we put the StackWatermark processing calls.
> 
> Note: that this doesn't fix a bug, it merely moves the processing code nearer the source of the problematic calls. I've found that jmm_GetThreadInfo looks straight into running thread's lock stacks without while those threads are running. That is a race that we should get rid of and I've created [JDK-8319899](https://bugs.openjdk.org/browse/JDK-8319899) for that issue.

This pull request has now been integrated.

Changeset: bbf52e0e
Author:    Stefan Karlsson <stefank at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/bbf52e0e4cb76b4c6425e7d1266dcdbb4df556ea
Stats:     17 lines in 2 files changed: 7 ins; 6 del; 4 mod

8319897: Move StackWatermark handling out of LockStack::contains

Reviewed-by: eosterlund, dholmes, dcubed

-------------

PR: https://git.openjdk.org/jdk/pull/16609