RFR: 8280056: gtest/LargePageGtests.java#use-large-pages failed "os.release_one_mapping_multi_commits_vm" [v4]

[Afshin Zafari]

On Wed, 15 Nov 2023 17:20:39 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove extra parameter for windows and bsd versions.
>
> test/hotspot/gtest/runtime/test_os.cpp line 565:
> 
>> 563:   ASSERT_NE(p, (address)nullptr);
>> 564: 
>> 565:   // reserve at border of the region
> 
> Can we have a bit more elaborate comment here, perhaps something like:
> 
> `// make things even more difficult by trying to reserve at the border of the region`

Done.

> test/hotspot/gtest/runtime/test_os.cpp line 570:
> 
>> 568:   PRINT_MAPPINGS("B");
>> 569: 
>> 570:   ASSERT_TRUE(p2 == nullptr || p2 == border);
> 
> Why are we allowing this case to fail?

There is no guarantee that the attempt will always be successful. By 'attempt', we mean that failing to reserve is also expected.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16240#discussion_r1397118520
PR Review Comment: https://git.openjdk.org/jdk/pull/16240#discussion_r1397115145