RFR: 8320370: NMT: Change MallocMemorySnapshot to simplify code. [v2]

Johan Sjölen jsjolen at openjdk.org
Mon Nov 20 13:35:54 UTC 2023


> Hi,
> 
> `MallocMemorySnapshot` used to be initialized in a quite non-standard way, using global placement new on an array of `size_t` of the size required to fit `MallocMemorySnapshot`. This looks like it was intended to circumvent some `ResourceObj` internals, but I'm unsure of its purpose. This change does what you expect a regular initialization of a global variable to look like.
> 
> ~Currently running through tier1.~ GHA passed and so did tier1 on Oracle CI.

Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:

  Thomas comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/16724/files
  - new: https://git.openjdk.org/jdk/pull/16724/files/319b89e2..3b1d7823

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16724&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16724&range=00-01

  Stats: 6 lines in 2 files changed: 0 ins; 5 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/16724.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16724/head:pull/16724

PR: https://git.openjdk.org/jdk/pull/16724


More information about the hotspot-runtime-dev mailing list