RFR: 8319137: SetNameAtExit fails with "assert(!is_null()) failed: Must be created" [v2]

Patricio Chilano Mateo pchilanomate at openjdk.org
Mon Nov 20 16:41:39 UTC 2023


On Mon, 20 Nov 2023 16:36:06 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> Please review the following fix which moves the release of the _object WeakHandle back to the ObjectMonitor dtor. Releasing it earlier as we do today introduces a race which can lead to crashes. Tested running tiers123 in mach5.
>> 
>> Thanks,
>> Patricio
>
> Patricio Chilano Mateo has updated the pull request incrementally with one additional commit since the last revision:
> 
>   inline release in ~ObjectMonitor()

> How much of this is a revert of [6402004](https://github.com/openjdk/jdk/commit/6402004852ccc993bb6e879c49fb71e2afdcdfbe)? Should we revert back to that state?
>
It's pretty much a revert of that.  Now only the deflater thread can call this code so I removed the extra branch in the delete loop.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16738#issuecomment-1819425228


More information about the hotspot-runtime-dev mailing list