RFR: 8309067: gtest/AsyncLogGtest.java fails again in stderrOutput_vm [v2]

Xin Liu xliu at openjdk.org
Mon Nov 20 17:29:52 UTC 2023


On Mon, 20 Nov 2023 14:33:21 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update per reviewer's feedback.
>
> test/hotspot/gtest/logging/test_asynclog.cpp line 248:
> 
>> 246: TEST_VM_F(AsyncLogTest, droppingMessage) {
>> 247:   if (AsyncLogWriter::instance() == nullptr)
>> 248:     return;
> 
> Please use braces, even for single statement if-bodies.

thanks. I resolve it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16728#discussion_r1399526985


More information about the hotspot-runtime-dev mailing list