RFR: 8319048: Monitor deflation unlink phase prolongs time to safepoint [v8]

Stefan Karlsson stefank at openjdk.org
Mon Nov 20 21:33:10 UTC 2023


On Mon, 20 Nov 2023 21:21:50 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

> I'm reading thru this PR yet again...
> 
> @fisk - In a comment above you have:
> 
> > 4. Walk said deflated monitors again through said external data structure, and unlink them from the in-use list
> 
> which is exactly the same as:
> 
> > 3. Walk said deflated monitors again through said external data structure, and unlink them from the in-use list
> 
> so I think that's an error. I think you mean that step 4 should be where we delete the ObjectMonitors and not unlink them again which we can't do...

Yes. I told Erik about this copy-n-paste error, but he didn't get around to fix the text.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16412#issuecomment-1819832304


More information about the hotspot-runtime-dev mailing list