RFR: 8320304: Refactor and simplify monitor deflation functions [v3]
Daniel D. Daugherty
dcubed at openjdk.org
Mon Nov 20 22:43:07 UTC 2023
On Mon, 20 Nov 2023 21:23:34 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>>>The call to log.before_blocked() on L1725 will stop the timer so it will not
>> be running during the ThreadBlockInVM.
>> The call to log.after_blocked() on L1731 will restart the timer.
>> The advantage of having these two calls is that you know how long we spent in ThreadBlockInVM based on the timestamps in the two log mesgs.
>>
>> It's unclear to me if you want me to change anything. Patricio pointed out that the pre-existing logs are around the "wrong" part of the code. It's not interesting to log the constructor, but rather the destructor. Alternatively, the code that deletes the monitors.
>
>>Definitely going to have to merge with JDK-8319137!!
>
> Of course. I had hoped that this would be pushed before that change.
I missed Patricio's point that the "work" time is done in the destructor and not in the
constructor. So my original logging was not useful (but it was fast!! :-)) and didn't
achieve the desired result.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16706#discussion_r1399834108
More information about the hotspot-runtime-dev
mailing list