RFR: 8319137: release _object in ObjectMonitor dtor to avoid races [v2]

Tue Nov 21 13:33:10 UTC 2023

On Tue, 21 Nov 2023 13:28:36 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

> > > Lgtm.
> > > Could potentially remove the `if (_object.is_null())` checks in `ObjectMonitor::object` and `ObjectMonitor::object_peek`. Should never take those branches.
> > 
> > 
> > @xmas92 is your comment/suggestion now invalidated by the issue we discovered with JNI monitor locking and rclaimed objects?
> 
> `WeakHandle::is_null` refers to the pointer into oop storage.

It is interesting that we have the `is_empty` method as well that does the same thing. Regardless these names should probably be cleared up. It is unclear if it refers to the `*oop` or the `oop`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16738#issuecomment-1820931818