RFR: 8319137: release _object in ObjectMonitor dtor to avoid races [v3]

Daniel D. Daugherty dcubed at openjdk.org
Tue Nov 21 17:42:12 UTC 2023


On Mon, 20 Nov 2023 17:37:15 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> Please review the following fix which moves the release of the _object WeakHandle back to the ObjectMonitor dtor. Releasing it earlier as we do today introduces a race which can lead to crashes. Tested running tiers123 in mach5.
>> 
>> This fix is an effective backout of [JDK-8256302](https://bugs.openjdk.org/browse/JDK-8256302).
>> 
>> Thanks,
>> Patricio
>
> Patricio Chilano Mateo has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove redundant branches

@robehn - [JDK-8256302](https://bugs.openjdk.org/browse/JDK-8256302) was originally
your idea that came up from another code review. Did you want to chime in on this review?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16738#issuecomment-1821372708


More information about the hotspot-runtime-dev mailing list