RFR: 8261837: SIGSEGV in ciVirtualCallTypeData::translate_from [v2]

[Vladimir Ivanov]

On Wed, 22 Nov 2023 00:48:26 GMT, Dean Long <dlong at openjdk.org> wrote:

>> src/hotspot/cpu/x86/interp_masm_x86.cpp line 58:
>> 
>>> 56: 
>>> 57: #ifdef _LP64
>>> 58:   assert_different_registers(obj, rscratch1, mdo_addr.base(), mdo_addr.index());
>> 
>> Same here: pass `rscratch1` unconditionally?
>
> Unfortunately, I don't know if mdo_addr.index() is a register.  I wish we had a smarter assert_different_registers() that would ignore multiple `noreg`.

Ok, I see. That's unfortunate. IMO it's perfectly fine to ignore `noreg` parameters in `assert_different_registers`. (After all, `noreg` is mostly unusable, so it doesn't matter whether there are multiple `noreg`s or just a single one passed.) But such a cleanup can be done later.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16750#discussion_r1401453822