RFR: 8275677: Test fails due to truncated hs_err file

David Holmes dholmes at openjdk.org
Sat Nov 25 02:33:18 UTC 2023


On Fri, 24 Nov 2023 07:54:08 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> This failure has not reproduced in mainline for a long while but as a preventative measure, at the suggestion of @JesperIRL , I've made a slight change to the register printing so that we always print the raw value before we start trying to figure out what it points to. That may shed some light on any future truncation.
>> 
>> Testing tiers 1-3 and manual inspection of hs_err files produced by tests
>> 
>> Thanks
>
> Is this really a problem in the latest sources? We made changes so that the raw value is always printed before we try to decode the value: [JDK-8284273](https://bugs.openjdk.org/browse/JDK-8284273) and the we've made it so that we continue with the rest of the register decoding if one of them fails: [JDK-8296469](https://bugs.openjdk.org/browse/JDK-8296469).
> 
> I'd like to see reproducer that creates a truncated hs_err file before we proceed with this change.

@stefank  thanks for that. I had not noticed that we now print the Registers before we print the (previously truncating) register mapping. IT does indeed seem like there is no point in my proposed enhancement now. I will close this PR. I will also close the bug as "not reproducible".

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16804#issuecomment-1826192277


More information about the hotspot-runtime-dev mailing list