RFR: 8319778: Remove unreachable code in ObjectSynchronizer::exit [v4]

[Axel Boldt-Christmas]

On Tue, 21 Nov 2023 14:30:55 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> In `ObjectSynchronizer::exit` when unlocking on an inflated monitor with `LM_LIGHTWEIGHT` there is a check if the owner is anonymous. That branch should never be take and would indicate that something is wrong with either `ObjectSynchronizer::inflate` or that `ObjectSynchronizer::exit` is trying to unlock a monitor not owned by the `current` thread.
>> 
>> Changes this to an assert instead. Did not condition the assert on `LM_LIGHTWEIGHT` as this property should hold regardless of locking mode.
>
> Axel Boldt-Christmas has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream_jdk/master' into JDK-8319778
>  - Merge remote-tracking branch 'upstream_jdk/master' into JDK-8319778
>  - Merge remote-tracking branch 'upstream_jdk/master' into JDK-8319778
>  - 8319778: Remove unreachable code in ObjectSynchronizer::exit

Ran the extra tier 1 tests on all platforms. Thanks for the reviews.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16602#issuecomment-1827258709