RFR: JDK-8319633: runtime/posixSig/TestPosixSig.java intermittent timeouts on UNIX [v3]

[Thomas Stuefe]

On Mon, 27 Nov 2023 13:28:41 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Joachim Kern has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   switch to Xint solution
>
> test/hotspot/jtreg/runtime/posixSig/TestPosixSig.java line 49:
> 
>> 47:             // We run the VM in interpreted mode, because the JIT might mark
>> 48:             // a Java method as not-entrant, which means turning the first opcode
>> 49:             // of the compiled method to NULL. Calling such a method after establishing
> 
> This comment is PPC64 specific. Please make it more general. That the instruction "0" generates SIGILL is specified by the PPC64 ISA and may be wrong for other platforms. Better would be "which means turning the first instruction into an illegal one".

Also would be good to mention that the problem is one of time: "If a SIGILL arrives after we redirected the signal handler but before the JNI checker noted the signal handler modification, the JVM may crash or hang; since SIGILLs may be generated by compiled code, we run interpreted".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16797#discussion_r1406168462