RFR: 8316234: AArch64: fastdebug build failure with GCC 12 and 13 due to -Wnonnull warning in vm_version_linux_aarch64.cpp [v2]

[Hao Sun]

On Mon, 27 Nov 2023 06:15:13 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> Hao Sun has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   print out the value for better debugging
>
> src/hotspot/os_cpu/linux_aarch64/vm_version_linux_aarch64.cpp line 184:
> 
>> 182: 
>> 183: static bool read_fully(const char *fname, char *buf, size_t buflen) {
>> 184:   assert(buf != nullptr && buflen >= 1, "invalid arguments");
> 
> Is it possible to dump the values of `buf` and `buflen` when the assert is hit?
> It would be more helpful for debugging.

Agree as the two checks are merged into one after this patch.

Updated in the latest commit.
Please help take a look at it. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16819#discussion_r1406992278