RFR: JDK-8319307: DCmds should not assert on truncation and should report truncation [v2]

[David Holmes]

On Wed, 8 Nov 2023 00:59:08 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into JDK-8319307-DCmds-should-not-assert-on-truncation-and-should-report-truncation
>>  - fix mac builds
>>  - JDK-8319307-DCmds-should-not-assert-on-truncation-and-should-report-truncation
>
> src/hotspot/share/nmt/memReporter.cpp line 323:
> 
>> 321:   const MallocSite* malloc_site;
>> 322:   int num_omitted = 0;
>> 323:   while (!output()->was_truncated() && (malloc_site = malloc_itr.next()) != nullptr) {
> 
> I don't think clients should be aware of, or worrying about truncation, this way. It seems very intrusive.

Again where do we inform the consumer of the stream that the content has been truncated?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16474#discussion_r1407296490