RFR: 8316234: AArch64: fastdebug build failure with GCC 12 and 13 due to -Wnonnull warning in vm_version_linux_aarch64.cpp [v2]

[Kim Barrett]

On Tue, 28 Nov 2023 02:21:26 GMT, Hao Sun <haosun at openjdk.org> wrote:

>> I tested {release, fastdebug, slowdebug} JDK builds with GCC 11/12/13 on AArch64, and fastdebug build with GCC 12 and 13 failed due to -Wnonnull warning.
>> 
>> The warning is raised because GCC 12 and 13 still think that `buf` can be null even if we have the assertion `assert(buf != nullptr, ...);`. Note that GCC 12 and 13 correctly determine the value range of `buflen`, i.e. `1 <= buflen <= 0xffff ffff ffff ffff`.
>> 
>> Note-1: Since it involves the analysis of `assert` statements, that's why release build can pass.
>> 
>> Note-2: I suppose that the incorrect optimization result of `nonnull/nullability` for variable `buf` only occurs at high GCC optimization levels. That's why slowdebug build can pass.
>> 
>> Note-3: To be honest, I didn't fully understand why this warning is raised by GCC 12 and 13. Recently we struggled with GCC 12 false positive warnings many times. See [1][2].
>> 
>> To suppress this warning, we try to fool GCC compiler via minor code change in this patch.
>> 
>> [1] https://bugs.openjdk.org/browse/JDK-8299580
>> [2] https://bugs.openjdk.org/browse/JDK-8294031
>
> Hao Sun has updated the pull request incrementally with one additional commit since the last revision:
> 
>   print out the value for better debugging

> From this patch #16550, I suppose that Oracle CI uses GCC 13.2.0.

Sorry about the confusion about the version.  Yes, Oracle CI uses GCC 13.2.0.

> Then I manually built GCC 13.2.0 on Ubuntu 22.04 (Note that the source code is downloaded from https://ftp.gnu.org/gnu/gcc/gcc-13.2.0/), and encountered the same `-Wnonnull` warning as well.

OK, that's really strange.  We (Oracle) cross-build linux-aarch64 from linux-x64 (CI uses Oracle Linux 8).  I can't
think of a reason why that would affect something like this, but it's another difference, in addition to Oracle Linux
vs Ubuntu.  I just did a build on Ubuntu 22.04 x64 with our cross-compiler, and see no warnings.  That compiler
was built on OL8, though again, not sure why any of that should matter.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16819#issuecomment-1829378750