RFR: JDK-8320830: [AIX] Dont mix os::dll_load() with direct dlclose() calls [v2]

[Thomas Stuefe]

On Thu, 30 Nov 2023 08:48:44 GMT, Joachim Kern <jkern at openjdk.org> wrote:

>> Joachim Kern has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   replaced local scope by class scope
>
> src/hotspot/os/aix/libodm_aix.cpp line 39:
> 
>> 37:   char ebuf[512];
>> 38:   _libhandle = os::dll_load(libodmname, ebuf, sizeof(ebuf));
>> 39: 
> 
> _libhandle is a class member. Here it was accidentally defined with function local scope, so the class member _libhandle stayed uninitialized. As a result the dll_unload() in the destructor worked with a garbage value of the class member. This change fixes this problem.

So the dllunload never worked, and we called dlclose with a garbage handle. Interesting that this never caused errors.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16846#discussion_r1410371747