RFR: 8317335: Build on windows fails after 8316645

Kim Barrett kbarrett at openjdk.org
Sun Oct 1 20:03:49 UTC 2023


On Sun, 1 Oct 2023 19:57:24 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Please review this trivial change that fixes a build failure with Visual
>> Studio in Oracle's CI. The failure is a constant truncation warning because
>> the constant initial value of a `char` member is 0xaa, which is out of range
>> for a signed 8bit char. This change uses 0x7a as the initial value, which is
>> in the required range.
>> 
>> Note that the problem code successfully builds in GitHub Actions.  I don't
>> know why we're seeing this problem in Oracle's CI but not GA; perhaps a
>> difference in compiler versions?
>> 
>> Testing:
>> mach5 tier1
>
> Marked as reviewed by lmesnik (Reviewer).

Thanks for the review @lmesnik

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16000#issuecomment-1742184955


More information about the hotspot-runtime-dev mailing list