RFR: 8315362: NMT: summary diff reports threads count incorrectly

[Johan Sjölen]

On Wed, 30 Aug 2023 11:11:12 GMT, Evgeny Ignatenko <duke at openjdk.org> wrote:

> 8315362: NMT: summary diff reports threads count incorrectly

src/hotspot/share/services/mallocTracker.cpp line 78:

> 76:   } else {
> 77:     assert(_thread_count == 0, "_thread_count can not be used if ThreadStackTracker::track_as_vm() == false");
> 78:     MallocMemorySnapshot* s = const_cast<MallocMemorySnapshot*>(this);

Why is this necessary instead of calling the method directly?

test/hotspot/jtreg/runtime/NMT/SummaryDiffThreadCount.java line 19:

> 17:  * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
> 18:  *
> 19:  * Please contact Azul Systems, 385 Moffett Park Drive, Suite 115, Sunnyvale,

This should be:


 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
 * or visit www.oracle.com if you need additional information or have any
 * questions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15490#discussion_r1342348767
PR Review Comment: https://git.openjdk.org/jdk/pull/15490#discussion_r1342353027