RFR: JDK-8316691: Heap dump: separate stack traces for mounted virtual threads [v3]
Serguei Spitsyn
sspitsyn at openjdk.org
Wed Oct 4 02:29:19 UTC 2023
On Wed, 4 Oct 2023 01:23:01 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> misspell getRefererId for consistency
>
> src/hotspot/share/services/heapDumper.cpp line 1579:
>
>> 1577:
>> 1578: _frames = new (mtServiceability) GrowableArray<StackFrameInfo*>(10, mtServiceability);
>> 1579: bool stopAtVthreadEntry = _thread_type == ThreadType::MountedVirtual;
>
> Nit: The naming convention is not camel case, so it has to be: `stop_at_vthread_entry`.
> My understanding that enterSpecial is considered as a special frame which is not belongs to VT stack trace.
That's right.
I forgot it is not returned by the `vframe::java_sender()`, so JVMTI `GetStackTrace()` does not return it as well.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15869#discussion_r1345089310
More information about the hotspot-runtime-dev
mailing list