RFR: 8317132: Prepare HotSpot for permissive- [v6]

[Kim Barrett]

On Wed, 4 Oct 2023 08:27:50 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Initialized thread in os_windows.cpp
>>  - Oops in os_windows.cpp
>>  - Remove goto in os_windows.cpp
>
> src/hotspot/share/memory/allocation.cpp line 114:
> 
>> 112: //
>> 113: 
>> 114: void* AnyObj::operator new(size_t size, Arena *arena) {
> 
> Is this function guaranteed to crash in case of allocation failure? @afshin-zafari removed `throw()` in the header file in 0f51e6326373ff7d4a4d9a0e3a2788401f73405d, but left the one here... should we restore the `throw()` in the header file instead?

[not a review, just a drive-by comment]
arena->Amalloc takes a second argument that defaults to EXIT_OOM, so this function does not return nullptr.
The earlier removal of the nothrow specification from the header was correct, but this one got missed, and
should be removed too.  So the change here is correct.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15955#discussion_r1345586912