RFR: 8317432: Async UL: Do not recompute strlen()

Johan Sjölen jsjolen at openjdk.org
Wed Oct 4 11:30:34 UTC 2023


On Tue, 3 Oct 2023 14:25:38 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Hi,
> 
> This change does three things:
> 
> 1. At construction of message we used to compute `strlen` and then `strcpy`, we change this to do only one `strlen` and then a `memcpy` instead.
> 2. A `strlen` used to be required to calculate the size when finding the next message in the iterator. We instead store the previously computed message length and so the `strlen` is no longer necessary. The cost of this is 8 bytes extra per message (64 -> 72 bytes).
> 3. There's also some code which alters the alignment to explicitly handle the alignment of `Message` and ensure that `_pos` starts at a `Message`-aligned pointer.

Saving the length can be done even earlier in the UL process, both for sync and async UL. This, in turn, allows us to use `fwrite` instead of `jio_fprintf` in `logFileStreamOutput.cpp:128`. Just some small ways of making UL a bit quicker.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16029#issuecomment-1746681352


More information about the hotspot-runtime-dev mailing list