RFR: 8317262: LockStack::contains(oop) fails "assert(t->is_Java_thread()) failed: incorrect cast to JavaThread"

David Holmes dholmes at openjdk.org
Thu Oct 5 02:00:09 UTC 2023


Please review this simple fix to `LockStack::is_owning_thread()` that allows it to be called by a non-JavaThread. Thanks to @pchilano  for the regression test.

Testing:
- new regression test
- runtime/handshake/MixedHandshakeWalkStackTest.java
- tiers 1-3 sanity

Thanks

-------------

Commit messages:
 - Adjust test as we don't expect any JVMTI errors.
 - Add regression test
 - 8317262: LockStack::contains(oop) fails "assert(t->is_Java_thread()) failed: incorrect cast to JavaThread"

Changes: https://git.openjdk.org/jdk/pull/16047/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16047&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8317262
  Stats: 101 lines in 2 files changed: 97 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/16047.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16047/head:pull/16047

PR: https://git.openjdk.org/jdk/pull/16047


More information about the hotspot-runtime-dev mailing list