RFR: 8317262: LockStack::contains(oop) fails "assert(t->is_Java_thread()) failed: incorrect cast to JavaThread"

David Holmes dholmes at openjdk.org
Thu Oct 5 06:45:08 UTC 2023


On Thu, 5 Oct 2023 06:06:15 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Please review this simple fix to `LockStack::is_owning_thread()` that allows it to be called by a non-JavaThread. Thanks to @pchilano  for the regression test.
>> 
>> Testing:
>> - new regression test
>> - runtime/handshake/MixedHandshakeWalkStackTest.java
>> - tiers 1-3 sanity
>> 
>> Thanks
>
> Looks reasonable.

Thanks for the review @tstuefe - and welcome back :)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16047#issuecomment-1748186003


More information about the hotspot-runtime-dev mailing list