RFR: 8317240: Promptly free OopMapEntry after fail to insert the entry to OopMapCache

Coleen Phillimore coleenp at openjdk.org
Thu Oct 5 12:53:48 UTC 2023


On Thu, 28 Sep 2023 12:27:52 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

> In OopMapCache::lookup(), after fail to insert newly created OopMapEntry to the cache, the new entry can be free immediately, because it is not published, not accessible by other thread.
> 
> The patch also refactored code a bit to reduce duplicate.
> 
> Test:
>    hotspot_gc on MacOSX (fastdebug and release)

Yes, this seems reasonable and nice to have a function for the duplicated deallocation code.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15963#pullrequestreview-1659780825


More information about the hotspot-runtime-dev mailing list