RFR: 8317262: LockStack::contains(oop) fails "assert(t->is_Java_thread()) failed: incorrect cast to JavaThread"

Patricio Chilano Mateo pchilanomate at openjdk.org
Thu Oct 5 14:25:28 UTC 2023


On Thu, 5 Oct 2023 01:47:03 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Please review this simple fix to `LockStack::is_owning_thread()` that allows it to be called by a non-JavaThread. Thanks to @pchilano  for the regression test.
> 
> Testing:
> - new regression test
> - runtime/handshake/MixedHandshakeWalkStackTest.java
> - tiers 1-3 sanity
> 
> Thanks

Looks good.

Patricio

-------------

Marked as reviewed by pchilanomate (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16047#pullrequestreview-1659972042


More information about the hotspot-runtime-dev mailing list