RFR: 8317433: Async UL: Only grab lock once when write():ing [v3]

Xin Liu xliu at openjdk.org
Thu Oct 5 17:25:19 UTC 2023


On Thu, 5 Oct 2023 10:06:31 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rewrite comment
>
> src/hotspot/share/logging/logAsyncWriter.cpp line 160:
> 
>> 158:         _lock.wait(0/* no timeout */);
>> 159:       }
>> 160:       // Only doing a swap and statistics under the lock to
> 
> @navyxliu 
> 
> The original comment was:
> 
>>`// lock protection. This guarantees I/O jobs don't block logsites.`
> 
> Does this change make sense to you?

yes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16030#discussion_r1347755190


More information about the hotspot-runtime-dev mailing list