RFR: 8317262: LockStack::contains(oop) fails "assert(t->is_Java_thread()) failed: incorrect cast to JavaThread"

David Holmes dholmes at openjdk.org
Fri Oct 6 05:40:00 UTC 2023


On Fri, 6 Oct 2023 05:30:47 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Please review this simple fix to `LockStack::is_owning_thread()` that allows it to be called by a non-JavaThread. Thanks to @pchilano  for the regression test.
>> 
>> Testing:
>> - new regression test
>> - runtime/handshake/MixedHandshakeWalkStackTest.java
>> - tiers 1-3 sanity
>> 
>> Thanks
>
> Looks good! Thanks!

Thanks for the review @rkennke !

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16047#issuecomment-1750011469


More information about the hotspot-runtime-dev mailing list