RFR: 8315362: NMT: summary diff reports threads count incorrectly [v2]
Evgeny Ignatenko
duke at openjdk.org
Tue Oct 10 07:37:55 UTC 2023
On Tue, 3 Oct 2023 09:00:23 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> Evgeny Ignatenko has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comments
>
> Hi,
>
> Thank you for this PR. This fix looks good to me, it's unfortunate that we have this `track_as_vm` condition spread throughout the code but we'll leave fixing that for a future PR.
>
> This is a Hotspot change, so you'll require 2 reviews (one from a Reviewer, which I am). After you've received to approvals I'll sponsor your change and you can merge it.
Hi @jdksjolen,
I have addressed all review comments here. Is it anything else I need to do before getting sponsored by you?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15490#issuecomment-1754585656
More information about the hotspot-runtime-dev
mailing list