RFR: 8315362: NMT: summary diff reports threads count incorrectly [v2]
Johan Sjölen
jsjolen at openjdk.org
Tue Oct 10 09:25:05 UTC 2023
On Tue, 10 Oct 2023 07:34:16 GMT, Evgeny Ignatenko <duke at openjdk.org> wrote:
>> Hi,
>>
>> Thank you for this PR. This fix looks good to me, it's unfortunate that we have this `track_as_vm` condition spread throughout the code but we'll leave fixing that for a future PR.
>>
>> This is a Hotspot change, so you'll require 2 reviews (one from a Reviewer, which I am). After you've received to approvals I'll sponsor your change and you can merge it.
>
> Hi @jdksjolen,
>
> I have addressed all review comments here. Is it anything else I need to do before getting sponsored by you?
Hi @zer0chance, thank you for the ping. I'll run this through Oracle CI and when it's finished and looks OK I'll sponsor.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15490#issuecomment-1754799134
More information about the hotspot-runtime-dev
mailing list