Integrated: JDK-8261894: Remove support for UseSHM
Thomas Stuefe
stuefe at openjdk.org
Tue Oct 10 11:20:31 UTC 2023
On Fri, 21 Jul 2023 10:14:14 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> We decided to ditch the SystemV-based large-page handling code in Linux a while ago. For history and details, please see JBS issue and the accompanying [CSR](https://bugs.openjdk.org/browse/JDK-8310841).
>
> This patch
>
> 1) removes the support for `-XX:+UseSHM` and all its backing code. It obsoletes `UseSHM`.
>
> 2) `UseSHM` had just been the negation of `UseHugeTLBFS` (in hindsight, a single mode switch would have been better). The POSIX-mmap-based implementation behind `UseHugeTLBFS` remains the sole implementation of static large pages in the JVM. The flag `UseHugeTLBFS` itself is not needed anymore since there is nothing to distinguish it from. Therefore I removed that flag, too.
>
> 3) `UseLargePages` and `UseTransparentHugePages` are unaffected. Their meaning remains the same:
> `UseLargePages` => using static hugepages
> `UseLargePages` + `UseTransparentHugePages` => using THPs
> `UseTransparentHugePages` => using THPs, enables also `UseLargePages`
>
> This allows for many code removals and simplifications. We can ditch the SystemV large page setup and management, its sanity tests, its regression tests, and associated documentation. We can also lose some of the tests, code, and documentation surrounding HugeTLBFS.
>
> Testing: I manually ran many tests with many different huge page settings on Linux x64. GHAs are green (one remaining x86 error is unrelated).
>
> Note that I will be out on vacation in September and may not respond to reviews in a timely fashion.
This pull request has now been integrated.
Changeset: c2abf120
Author: Thomas Stuefe <stuefe at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/c2abf120bc231c58de983329cd6c312d18f0e115
Stats: 649 lines in 8 files changed: 24 ins; 564 del; 61 mod
8261894: Remove support for UseSHM
Reviewed-by: dholmes, ayang
-------------
PR: https://git.openjdk.org/jdk/pull/14970
More information about the hotspot-runtime-dev
mailing list